Use config files for the lobby bots #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using environment variables for configuration, this switches to using configuration files for the configuration of the lobby bots. This ensures that that sensitive configuration values aren't visible in the process list anymore. Deploying this requires adjusting the lobby configuration files to account for the changed key names. An example for that is included in the changes to `config-lobby-vagrant.yml` as part of this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using environment variables for configuration, this switches to using configuration files for the configuration of the lobby bots. This ensures that that sensitive configuration values aren't visible in the process list anymore.
Deploying this requires adjusting the lobby configuration files to account for the changed key names. An example for that is included in the changes to
config-lobby-vagrant.ymlas part of this commit.