Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent AO depending on scene scale #30

Open
MajorMeerkatThe3rd opened this issue Aug 30, 2023 · 1 comment · May be fixed by #35
Open

Consistent AO depending on scene scale #30

MajorMeerkatThe3rd opened this issue Aug 30, 2023 · 1 comment · May be fixed by #35
Labels
bug Something isn't working

Comments

@MajorMeerkatThe3rd
Copy link

Hello, I'm having an issue setting up the AO (both HBAO and SSAO) with varying scene sizes.

In this first example, I have a pretty standard setup with the HBAO effect. Everything works as expected.

When I now introduce a scalingFactor that scales all elements in the scene as in this second example, the results of the AO are not consistent. I tried to adjust the distance, thickness and radius by the scalingFactor with no success.

Is there a way to achieve consistent AO results depending on the scene scale?
@MajorMeerkatThe3rd MajorMeerkatThe3rd linked a pull request Sep 26, 2023 that will close this issue
Open
@0beqz
Copy link
Owner

0beqz commented Apr 5, 2024

Hey, apologies for the delay.
Right now the second version is in the works which is also why I couldn't give you a straight solution.
Right now, HBAO is very basic so things like scene scale aren't taken into account. So there isn't a way at the moment.
I'll check it out, thanks for reporting!

@0beqz 0beqz added the bug Something isn't working label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ao distance value usage MajorMeerkatThe3rd/realism-effects
2 participants
@MajorMeerkatThe3rd @0beqz