Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential database connection leak #3516

Open
0xyjk opened this issue Apr 3, 2024 · 0 comments
Open

Potential database connection leak #3516

0xyjk opened this issue Apr 3, 2024 · 0 comments

Comments

@0xyjk
Copy link

0xyjk commented Apr 3, 2024

database rows does not closed

correct usage:

func queryRows() ([]A, error) {
    rows, err := db.Query("SELECT ....)
    if err != nil {
        return nil, err
    }
    defer rows.Close()

    var as []A

    for rows.Next() {
        var a A
        if err := rows.Scan(....); err != nil {
            return nil, err
        }
        as= append(as, a)
    }
    if err = rows.Err(); err != nil {
        return nil, err
    }
    return as, nil
}

should check rows.Err() for all query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant