Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting final proof generating_since field to null before the proof has sent and confirmed in L1 #3645

Open
agnusmor opened this issue May 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working zkevm-seq-agg
Milestone

Comments

@agnusmor
Copy link
Contributor

Now when sending a final proof to L1 we are setting the generating_since field of this proof to null before the L1 tx is confirmed (while waiting for this confirmation), this can cause an edge scenario where that proof can be "reused" by a prover to aggregate it to an existing aggregation. When this happened an "invalid" aggregation proof is created, since this proof contains a proof (batches) that are already verified, therefore, the aggregator never consider this proof as final to send it to L1 (since it starts from a batch previous to the last one verified). To fix this scenario we needed to delete that proof from state.proof table and regenerate it.

To correctly fix this issue we need to ensure that generating_since field is kept to a date (not null) until the tx that is sending the proof to be verfiied in L1 is confirmed. After the L1 tx is confirmed we can set the field to null or delete directly the proof from the state.proof table

@agnusmor agnusmor added bug Something isn't working zkevm-seq-agg labels May 22, 2024
@agnusmor agnusmor added this to the v0.7.0 milestone May 22, 2024
@agnusmor agnusmor self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working zkevm-seq-agg
Projects
None yet
Development

No branches or pull requests

1 participant