Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to criterion for benchmarks, expand benchmarks #27

Closed
wants to merge 1 commit into from
Closed

Switch to criterion for benchmarks, expand benchmarks #27

wants to merge 1 commit into from

Conversation

dralley
Copy link

@dralley dralley commented Jul 10, 2022

Compare against std::collections::HashMap

closes #26

@pmarks
Copy link
Contributor

pmarks commented Jul 11, 2022

@dralley cool, looks helpful! couple of rustfmt complaints - we're using Rust 1.55 in CI, but we could update.

@dralley
Switch to criterion for benchmarks, expand benchmarks
167b99c 
Compare against std::collections::HashMap

closes #26
@adam-azarchs
Copy link
Member

Checks are complaining because one of the introduced dependencies requires 2021 edition. I've updated the CI version of rust, so that won't block it any more, but you'll need to rebase your branch to pick that up.

@dralley dralley closed this by deleting the head repository Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmarks should compare lookup against std::collections::HashMap and FxHashMap
3 participants
@dralley @pmarks @adam-azarchs