-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Support for PHPUnit 3.7.x #28
Comments
What are the implications of dropping support? Will it straight up break peoples test suites or will it be a more graceful "o hai, you're using a deprecated method, maybe you should update your tests?"-type warning? |
If they're requiring phpunit < 4.0, composer would fail to run install and update because no valid installation candidate could be found. |
I'm certainly not sold on the idea of dropping 3.7.x, though. Currently, I have a workaround to deal with the possible absence of risky tests. This is more of a "do we want to keep supporting old versions of phpunit?" conversation, not "PLZ I NEED THIS THING". |
If we want to follow the release pattern set by PHPUnit, could be dropped at any time, as 4.0.0 was released March 7, 2014, making it at least one year since the next major series was released. You know, if you needed a push ;) |
Hahaha @stevegrunwell I was just about to link both of those. :D |
I'm going to go ahead and say this should be revisited later. For now, keeping support doesn't cost us very much in terms of effort and a lot of WordPress developers are still using 3.7. |
Closing to revisit later, as changes for #88 might break compatibility anyway. |
For what it's worth @ericmann, the |
I wanted to start a discussion around this idea. The last release on the 3.x branch was 6 months ago. I'm not sure if the branch has received its EOL yet. Will investigate.
Anyway, 4.0 introduced a lot of nice things. I'm primarily interested in the addition of the concept of "risky" tests for #18.
The text was updated successfully, but these errors were encountered: