Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Support for PHPUnit 3.7.x #28

Closed
johnpbloch opened this issue Apr 13, 2015 · 8 comments
Closed

Drop Support for PHPUnit 3.7.x #28

johnpbloch opened this issue Apr 13, 2015 · 8 comments

Comments

@johnpbloch
Copy link
Contributor

I wanted to start a discussion around this idea. The last release on the 3.x branch was 6 months ago. I'm not sure if the branch has received its EOL yet. Will investigate.

Anyway, 4.0 introduced a lot of nice things. I'm primarily interested in the addition of the concept of "risky" tests for #18.

@stevegrunwell
Copy link
Contributor

What are the implications of dropping support? Will it straight up break peoples test suites or will it be a more graceful "o hai, you're using a deprecated method, maybe you should update your tests?"-type warning?

@johnpbloch
Copy link
Contributor Author

If they're requiring phpunit < 4.0, composer would fail to run install and update because no valid installation candidate could be found.

@johnpbloch
Copy link
Contributor Author

I'm certainly not sold on the idea of dropping 3.7.x, though. Currently, I have a workaround to deal with the possible absence of risky tests.

This is more of a "do we want to keep supporting old versions of phpunit?" conversation, not "PLZ I NEED THIS THING".

@stevegrunwell
Copy link
Contributor

If we want to follow the release pattern set by PHPUnit, could be dropped at any time, as 4.0.0 was released March 7, 2014, making it at least one year since the next major series was released.

You know, if you needed a push ;)

@johnpbloch
Copy link
Contributor Author

Hahaha @stevegrunwell I was just about to link both of those. :D

@johnpbloch
Copy link
Contributor Author

I'm going to go ahead and say this should be revisited later. For now, keeping support doesn't cost us very much in terms of effort and a lot of WordPress developers are still using 3.7.

@ericmann
Copy link
Collaborator

Closing to revisit later, as changes for #88 might break compatibility anyway.

@johnpbloch
Copy link
Contributor Author

For what it's worth @ericmann, the dev branch already requires PHPUnit >=4.3/<6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants