Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: learn if github auth supports either org or team authorization #2179

Closed
consideRatio opened this issue Feb 8, 2023 · 5 comments
Closed
Assignees
Labels
Documentation A change to our documentation.

Comments

@consideRatio
Copy link
Member

consideRatio commented Feb 8, 2023

The grafana documentation on github auth wasn't clear with regards to if allowed_organizations and team_ids could be used together, or how a team id would be specified.

If we can verify that we can provide access to github teams as well besides access to us in the github org 2i2c-org, that will help when asking users if they want a certain group of users to be granted grafana access via github identities.

Related

@GeorgianaElena
Copy link
Member

@consideRatio, I believe there was some discussion or mention of some relevant docs of some sort in #1570

@colliand
Copy link
Contributor

colliand commented Feb 8, 2023

Thanks for creating this issue. I point this discussion out to @jmunroe as it overlaps with support discussions with Luis Lopez (betolink on GitHub). Once the technical issues are resolved, 2i2c Partnerships and Community should adapt this documentation which is mostly focused on 2i2c's internal usage to a wider scope that includes community usage of Grafana dashboards.

@yuvipanda
Copy link
Member

https://infrastructure.2i2c.org/en/latest/sre-guide/support/grafana-account.html?highlight=grafana is the current method of giving out access to grafana for hub admins, and they can add other users there as desired.

@consideRatio consideRatio changed the title Learn if grafana github auth supports either org or team authorization grafana: learn if github auth supports either org or team authorization Feb 16, 2023
@consideRatio consideRatio added the Documentation A change to our documentation. label Feb 16, 2023
@consideRatio
Copy link
Member Author

I think we shouldn't dig into github based authentication further for grafana hubs, but instead resort to jupyterhub as an identity provider or settle with either github org or individual user/pass accounts.

Closing this for now.

@consideRatio
Copy link
Member Author

I learned something more, and concluded that use of the GitHub API can reveal IDs of github organization's teams, and they can be used.

Messy though. To inspect things like this via the GitHub REST API, its nice to use gh the CLI.

For example, to get info about a github org you can do:

gh api /orgs/smithsonian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation A change to our documentation.
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants