-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Popup: move related child in corresponding popup_lizmap_dd_relation div #4768
Conversation
As side effect, the The display effect is to much "heavy" IMHO and could be better. I guess there are two options here:
Since class What do you think about it? |
@Gustry any advice about the CSS ? |
3e1e2e8
to
29ae051
Compare
You mean about the styling side ? |
just for trying, I've added a couple of css rules in div.popup_lizmap_dd div.tab-content div.tab-pane div.popup_lizmap_dd_relation div,
div.popup_lizmap_dd div.tab-content div.tab-pane div.popup_lizmap_dd_relation
{
border: 0px;
border-radius: 0px;
background-color:white;
} result is: What do you think about it? Thanks |
Thanks for your contribution. I would really like to spend some time to make this automatic popup look like the editing form, with labels aside the values, and a more compact UX. We should modify LWC PHP code but also the Python plugin (I think) to improve the automatic "form-like" view of the popup |
I agree, I'm thinking about it too but there's probably a lot work to do and, with the new Anyway, basically with this PR nothing changes :), just put things in the right place (or at least, try to) Thanks |
Ok for me. I will spend some time when implementing the lizmap-features-table component. |
When a
Popup
is displayed with the QGIS Drag and Drop configuration, for each relations configured in the layout a container HTML element (div.popup_lizmap_dd_relation
) is added to the Popup (see 3liz/qgis-lizmap-server-plugin@6a42400)This PR moves the related child (or children) popup in corresponding
popup_lizmap_dd_relation
div. The feature covers both1:n
andn:m
relationsTicket : fix #4407
Backport to 3.8
Funded by Faunalia