Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code quality control actions #13

Open
2 of 3 tasks
rldhont opened this issue Jan 18, 2021 · 1 comment
Open
2 of 3 tasks

Add code quality control actions #13

rldhont opened this issue Jan 18, 2021 · 1 comment
Assignees
@nboisteault

Comments

@rldhont
Copy link
Contributor

rldhont commented Jan 18, 2021 •
edited by nboisteault
Loading

As for lizmap-web-client, add the actions:

  • php-cs-fixer
  • eslint
  • phpstan
@nboisteault nboisteault self-assigned this May 11, 2022
@Gustry
Copy link
Member

Gustry commented Jun 16, 2022

Eslint is checked but there are still some issues when running it on local.
Just tried in 9e7af97

Errors are in wps/www/wps.js

For phpstan, this is another issue. It's difficult to run it with the LWC context. There are some false positive issue for now when running it in modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nboisteault nboisteault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rldhont @Gustry @nboisteault @pdrillin