This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Fixed issue #30 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toufik-airane
suggested changes
Jun 23, 2020
There was a problem hiding this comment.
Dear @plane000,
Can you explain how you managed to fix the security vulnerability?
Reading the code changes, I'm not sure about the efficiency of the fix.
It seems that you just rename the arg to id.
Thank you.
|
Sorry @benkyd, we enjoyed reviewing your fix but it has not been selected this time. If this bounty has not been closed, please feel free to try again with a new pull request! We appreciate your effort and look forward to reviewing more of your fixes in the future! 🔨😎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed according to Issue #30, I also renamed arg to id, to make it more similar to the one used in mongo-db, a slight performance impact might be noted as the ID doesnt return in certain cases.
Bounty URL: https://www.huntr.dev/app/bounties/open/1-npm-bson-objectid
Implemented the fix described in Issue cabinjs#30
PoF
All tests pass