Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send captions of "document" attachments to Whatsapp rooms #1925

Closed
ilmaisin opened this issue Nov 18, 2022 · 2 comments
Closed

Send captions of "document" attachments to Whatsapp rooms #1925

ilmaisin opened this issue Nov 18, 2022 · 2 comments

Comments

@ilmaisin
Copy link
Contributor

Describe the bug
Captions of "document" attachments are not send to Whatsapp rooms. Only the file attachment is sent.

To Reproduce
Send a file containing both a video and text to a Telegram room that is bridged with a WA room

Expected behavior
Both text and video should appear in the Whatsapp room

Screenshots/debug logs
If applicable, add screenshots to help explain your problem.
Use logs from running matterbridge -debug if possible.

Environment (please complete the following information):

  • OS: linux

  • Matterbridge version: 1.25.3-dev

  • If self compiled: output of git rev-parse HEAD While I have built my matterbridge myself per these instructions, I cannot find any relevant git repository from my system.

Additional context
Image captions are sent just fine.

This file apparently has specific code to handle captions for "image" messages, but not for "document" messages.

@ilmaisin
Copy link
Contributor Author

#1652 A similar issue was fixed last year but for Discord instead of Whatsapp.

@ilmaisin ilmaisin changed the title Send captions of file attachments to Whatsapp rooms Send captions of "document" attachments to Whatsapp rooms Nov 20, 2022
@42wim
Copy link
Owner

42wim commented Nov 26, 2022

Fixed by your own PR :)

@42wim 42wim closed this as completed Nov 26, 2022
@42wim 42wim added the whatsapp label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants