fix: Shallow equality check on cache parsing input #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A change introduced in Next.js 15.0.0-canary.41 (precisely vercel/next.js#67105) broke the referential stability that the cache.parse method was expecting to detect `parse` being called with the same search params. Now we're using a deep equality check by caching the serialized query string that was parsed, and comparing it with the input when called again.
franky47
force-pushed
the
fix/search-params-deep-equals
branch
from
9642846
to
9000440
Compare
While the searchParams object is not referentially stable, its values are, so we can do a simple shallow comparison. Adding a test case in the e2e test to make sure this holds with array of values (repeated keys in the query string).
franky47
changed the title
|
🎉 This PR is included in version 1.17.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change introduced in Next.js 15.0.0-canary.41 (precisely vercel/next.js#67105) broke the referential stability that the cache.parse method was expecting to detect
parsebeing called with the same search params.Now we're using a shallow equality check, as the values seem to still be referentially stable.