fix: Use optimistic search params in app router #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
franky47
changed the title
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: |
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a combination of
shallow: false,startTransition(fromuseTransition), and slow RSC computation, there can be a race condition where sending two or more updates before the first RSC response arrives, the useSearchParams update with the intermediate value and cause optimistic URL & UI updates (internal state) to sync to incorrect values. When the last RSC payload finished streaming in, the whole UI became eventually consistent, but this caused flickering issues.Fixing this by feeding the nuqs hooks an optimistic version of
useSearchParamsin the app router adapter, and triggering this optimistic update when updating the URL (where we already do this kind of optimistic update with a shallow update before calling the router).See #714.