Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the testing adapter clear the URL queue #764

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

franky47
Copy link
Member

This caused issues in sequential tests where a test would update a query state, the URL update would be queued, but not flushed at the moment when the test finished, and the next test would then pick up the queued value in its initial state.

This caused issues in sequential tests where a test would
update a query state, the URL update would be queued, but
not flushed at the moment when the test finished, and the
next test would then pick up the queued value in its initial state.
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 0:37am

@franky47 franky47 added the adapters/testing Uses the testing adapter for mocking URL behaviours in tests label Nov 14, 2024
@franky47 franky47 added this to the 🪵 Backlog milestone Nov 14, 2024
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/nuqs@764

commit: 261cd95

@franky47 franky47 merged commit 8200add into next Nov 14, 2024
27 checks passed
@franky47 franky47 deleted the fix/testing-clear-update-queue branch November 14, 2024 13:02
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 removed this from the 🚀 Shipping next milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters/testing Uses the testing adapter for mocking URL behaviours in tests released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant