-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
升級 rails 7.1 + ruby 3.2 #512
Comments
@phrase5036 test |
@phrase5036 test2 |
先升級 tyr => https://d.pr/v/VZqlJl |
@phrase5036 上面看完後給我一個你打算開始處理這張票的時間點以及 deadline |
@marsz 看完,之前有參考 railsdiff 升級過,我知道怎麼升級。 tyr 開
template 開
是這樣對吧嗎? 明天就可以開始處理這件事,不過應該是 bznk 那邊下班後再處理,會分幾天做。一天預計花兩小時。 |
@phrase5036 |
@marsz 好 |
@marsz
今天沒進展,明日再戰 |
@phrase5036 我自己是這樣 rvm install 3.2 --with-openssl-dir=$(brew --prefix)/opt/openssl@3 在這之前要先用 rvm 和 brew 確認一些東西
不過我的筆電還沒裝成功 我先來試試看筆電 |
@marsz 我昨天試製過這一整串了🤣 雖然大部分都說跟 openssl 有關,不過還是 not work for me |
@phrase5036 rvm 有更新到 master 嗎? rvm get master |
@marsz 我是 rvm get stable |
@phrase5036 用 rvm get master 看看 |
@marsz 好哦,感謝 |
@phrase5036 我的筆電裝成功了 看起來 rvm get master 是關鍵 |
@marsz +__rvm_make:0> make -j12
BASERUBY = /Users/phrase5036/.rvm/rubies/ruby-2.3.3/bin/ruby --disable=gems
CC = gcc
LD = ld
LDSHARED = gcc -dynamiclib
CFLAGS = -O3 -I/usr/local/opt/libyaml/include -I/usr/local/opt/libksba/include -I/usr/local/opt/readline/include -I/usr/local/opt/zlib/include -I/usr/local/opt/[email protected]/include -fdeclspec -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wextra-tokens -Wdeprecated-declarations -Wdivision-by-zero -Wdiv-by-zero -Wimplicit-function-declaration -Wimplicit-int -Wmisleading-indentation -Wpointer-arith -Wshorten-64-to-32 -Wwrite-strings -Wold-style-definition -Wmissing-noreturn -Wno-constant-logical-operand -Wno-long-long -Wno-missing-field-initializers -Wno-overlength-strings -Wno-parentheses-equality -Wno-self-assign -Wno-tautological-compare -Wno-unused-parameter -Wno-unused-value -Wunused-variable -Wundef -fno-common -pipe
XCFLAGS = -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-overflow -fvisibility=hidden -DRUBY_EXPORT -I. -I.ext/include/x86_64-darwin22 -I./include -I. -I./enc/unicode/15.0.0
CPPFLAGS = -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT
DLDFLAGS = -L/usr/local/opt/libyaml/lib -L/usr/local/opt/libksba/lib -L/usr/local/opt/readline/lib -L/usr/local/opt/zlib/lib -L/usr/local/opt/[email protected]/lib -install_name /Users/phrase5036/.rvm/rubies/ruby-3.2.2/lib/libruby.3.2.dylib -compatibility_version 3.2 -current_version 3.2.2 -fstack-protector-strong -framework CoreFoundation -fstack-protector-strong -framework CoreFoundation
SOLIBS = -lgmp -ldl -lobjc -lpthread
LANG = zh_TW.UTF-8
LC_ALL =
LC_CTYPE =
MFLAGS = - --jobserver-fds=3,4 -j
RUSTC = no
YJIT_RUSTC_ARGS = --crate-name=yjit --crate-type=staticlib --edition=2021 -g -C opt-level=3 -C overflow-checks=on '--out-dir=/Users/phrase5036/.rvm/src/ruby-3.2.2/yjit/target/release/' ./yjit/src/lib.rs
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
compiling ./main.c
compiling dmydln.c
compiling miniinit.c
compiling dmyext.c
translating probes probes.d
compiling ast.c
compiling bignum.c
compiling class.c
compiling compar.c
compiling compile.c
compiling complex.c
compiling cont.c
compiling debug.c
. ./vm_opts.h
compiling debug_counter.c
compiling dir.c
compiling dln_find.c
In file included from debug.c:27:
./vm_callinfo.h:177:9: error: use of undeclared identifier 'RUBY_FUNCTION_NAME_STRING'
rp(ci);
^
./internal.h:94:72: note: expanded from macro 'rp'
#define rp(obj) rb_obj_info_dump_loc((VALUE)(obj), __FILE__, __LINE__, RUBY_FUNCTION_NAME_STRING)
^
compiling encoding.c
compiling enum.c
In file included from debug.c:27:
./vm_callinfo.h:218:16: error: use of undeclared identifier 'RUBY_FUNCTION_NAME_STRING'
if (debug) rp(ci);
^
./internal.h:94:72: note: expanded from macro 'rp'
#define rp(obj) rb_obj_info_dump_loc((VALUE)(obj), __FILE__, __LINE__, RUBY_FUNCTION_NAME_STRING)
^
2 errors generated.
make: *** [debug.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from compile.c:40:
./vm_callinfo.h:177:9: error: use of undeclared identifier 'RUBY_FUNCTION_NAME_STRING'
rp(ci);
^
./internal.h:94:72: note: expanded from macro 'rp'
#define rp(obj) rb_obj_info_dump_loc((VALUE)(obj), __FILE__, __LINE__, RUBY_FUNCTION_NAME_STRING)
^
In file included from compile.c:40:
./vm_callinfo.h:218:16: error: use of undeclared identifier 'RUBY_FUNCTION_NAME_STRING'
if (debug) rp(ci);
^
./internal.h:94:72: note: expanded from macro 'rp'
#define rp(obj) rb_obj_info_dump_loc((VALUE)(obj), __FILE__, __LINE__, RUBY_FUNCTION_NAME_STRING)
^
2 errors generated.
make: *** [compile.o] Error 1
+__rvm_make:0> return 2 最後裝上電腦的做法是
|
rbenv/ruby-build#1938 (comment) |
@marsz 有可能,但我OSX13已經是最新的xcode。如果要再升要先升 OSX |
@phrase5036 好吧 你先繼續走下去 回頭再來處理安裝問題 |
@marsz 今日回報 bundle install and bundle update 已解決 dependency 的問題,bundle install & update works. 目前開始跑 rake spec 處理 railsdiff 及修正相關問題了 |
|
@marsz
目前死在 |
https://github.com/5fpro/tyr/pull/270/files 這是之前升級的 PR ,可以參考部分 |
@marsz 修復紀錄 factory_bot_rails 需要降版,否則啟動會有錯誤
Time#to_s -> Time#to_fs 測試修正紀錄 rspec spec/requests/tyr/edms_controller_spec.rb:12 rspec spec/values/tappay/invoice_spec.rb:28 rspec spec/requests/tyr/admin/transaction_logs_controller_spec.rb:8 rspec spec/requests/tyr/linebots_controller_spec.rb:14 rspec spec/requests/tyr/users/confirmations_controller_spec.rb:9 |
@marsz 剩餘19條 error 未修正,總共七大類 測試未修正,這些我有稍微找一下,但感覺特難修。所以列出來跟你討論看看
|
linebots_controller => https://d.pr/v/YmL7uK 我還沒推,推完會再跟你說 |
@marsz tyr 補了一個 commit,跑 rails-template 的時候會壞掉 https://github.com/5fpro/tyr/commit/10689fd74037f114cb9893d9993f1a9ab8ccb4a1 |
https://railsdiff.org/6.0.6.1/7.1.2
The text was updated successfully, but these errors were encountered: