Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to request JSON chat completion due to private field #137

Closed
zackangelo opened this issue Nov 7, 2023 · 2 comments · Fixed by #139
Closed

Unable to request JSON chat completion due to private field #137

zackangelo opened this issue Nov 7, 2023 · 2 comments · Fixed by #139

Comments

@zackangelo
Copy link

ChatCompletionResponseFormat was introduced to support JSON output in the chat completions API, but I believe the r#type field should be public instead of private? Apologies if I'm missing something. Happen to open a PR if this is the case.
@64bit
Copy link
Owner

64bit commented Nov 7, 2023 •
edited
Loading

Oh dang, thats a bug. PR is most welcome!

All fields of any request response types should be public.

@64bit 64bit mentioned this issue Nov 8, 2023
Merged
@64bit 64bit closed this as completed in #139 Nov 8, 2023
@64bit
Copy link
Owner

64bit commented Nov 8, 2023

Hello, fix for pub visibility is added in v0.16.1.

Thank you for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing pub modifiers 64bit/async-openai
2 participants
@zackangelo @64bit