Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code 2 is not only for invalid input file! #44

Closed
ThaDaVos opened this issue Jun 9, 2019 · 4 comments
Closed

Code 2 is not only for invalid input file! #44

ThaDaVos opened this issue Jun 9, 2019 · 4 comments

Comments

@ThaDaVos
Copy link

ThaDaVos commented Jun 9, 2019

When Handbrake throws Error code 2 this is not always that the input file is invalid but also that the Preset is invalid - took me a while to figure that out...
@75lb
Copy link
Owner

75lb commented Jun 19, 2019

When Handbrake throws Error code 2

which error code do you mean? Are you referring to error.errno thrown by the error event? Or are you talking about the exit code returned by the handbrake-js cli?

@ThaDaVos
Copy link
Author

The one used here: https://github.com/75lb/handbrake-js/blob/master/lib/Handbrake.js#L124

@75lb 75lb closed this as completed in 2f59701 Jun 19, 2019
@75lb
Copy link
Owner

75lb commented Jun 19, 2019

Fixed and released in handbrake-js v4.0.0. I added the INVALID_PRESET exception. Thanks for letting me know.

@ThaDaVos
Copy link
Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@75lb @ThaDaVos