Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] distrobox assemble --replace/-R is very risky #841

Closed
nain-F49FF806 opened this issue Jul 6, 2023 · 1 comment
Closed

[Discussion] distrobox assemble --replace/-R is very risky #841

nain-F49FF806 opened this issue Jul 6, 2023 · 1 comment
Labels
question Further information is requested

Comments

@nain-F49FF806
Copy link

Is your feature request related to a problem? Please describe.

I use custom home for my distroboxes. While trying out the distrobox assemble I decided to test the replace option.
I expected it to delete the container, but not the files stored in the custom home. Either way, before running such a destructive operation, it would certainly ask me, .. right? Just like the distrobox rm command I had run manually seconds before.

Nope. No confirmation. distrobox assemble immediately started the cleanup operation, leaving me perplexed about where the confirmation prompt is. Fortunately, I had verbose on and noticed it was already deleting and could Ctrl+C before much damage was done. I still don't know how much data it was able to delete though, if any

Describe the solution you'd like

When running distrobox assemble with --replace/-R or replace=true in distrobox.ini, it should leave the custom home alone or prompt for confirmation if deleting custom home is desired.

We want to replace the container, not nuke associated user data.

@nain-F49FF806 nain-F49FF806 added the question Further information is requested label Jul 6, 2023
@nain-F49FF806
Copy link
Author

P.S : I can help with the code if the recommended behaviour is agreed upon. Wanted to seek your thoughts on this before making changes / sending PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant