-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashes in secret service backend break roundtrip #82
Comments
Simplified my branch a bit: you merely need to re-open to see the problem.
|
https://github.com/gsterjov/go-libsecret/blob/master/service.go not seeing any normalization going on here. https://freedesktop.org/wiki/Specifications/secret-storage-spec/secrets-api-0.1.html#object-paths says:
(Elsewhere they use "encoded" to mean "encrypted", but I don't see how that makes sense in this context.) |
1d6ce07 shows that the collection path we get back is different than the one we supplied:
|
I see in my
|
that's because in linux i'll submit pr |
submitted pr |
#83 FYI Thanks @leejw51crypto ! |
Hi, looks like if you've got a dash in
ServiceName
in the secret service backend, it will fail to find it next time.Here's a test:
ad34891
^ running
gnome-keyring-daemon
in the background.I noticed through
dbus-monitor
that the actual collection name iskeyring_2dtest
, with some sort of escaping applied to the-
character. I'm not deep into DBus/Secret Service, but it looks like sort of like URI escaping, likeurl.PathEscape
.Needs some more investigation, but yeah, 100% busted.
The text was updated successfully, but these errors were encountered: