Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetrization layer #42

Closed
CheukHinHoJerry opened this issue Jun 6, 2023 · 8 comments
Closed

Symmetrization layer #42

CheukHinHoJerry opened this issue Jun 6, 2023 · 8 comments

Comments

@CheukHinHoJerry
Copy link
Collaborator

CheukHinHoJerry commented Jun 6, 2023

I am doing that for single species case, after confirming it works fine I will then do that for multi-specices case.

A minor issue is that currently RepLieGroups is using P4ML so there is a circular dependency issue. However in RepLieGroups/src we do not need P4ML and we should remove that from deps.

@cortner
Copy link
Member

cortner commented Jun 6, 2023

I agree. RepLieGroups only needs to be assured that the basis transforms as expected.

However, I'm not convinced that P4ML should depend on RepLieGroups. For now can we please work in a separate "drafting repo"? I will create that now.

@CheukHinHoJerry
Copy link
Collaborator Author

CheukHinHoJerry commented Jun 6, 2023

Just done a first draft on this and I will wait for the 2023MitacsDV repo to set up before I push the code.

@cortner
Copy link
Member

cortner commented Jun 6, 2023

That repo is already ready. Just create a folder inside, eg call it jhh_ace1 with a Project and example script.

@cortner
Copy link
Member

cortner commented Jun 8, 2023

We should think about how we can do the synmetrisation layer for real SH. Probably not hard, probably can be reduced to specifying the CG for rSH which should be a trivial linear transformation.

@cortner
Copy link
Member

cortner commented Jul 27, 2023

@CheukHinHoJerry -- I talked to @zhanglw0521 about creating another package called EquivariantLux.jl in which we make available utility functions to build equivariant models from RepLie and P4ML. We can also develop some example models in that package. It could be a sort of intermediate layer between RepLie, P4ML and ACE.

@zhanglw0521
Copy link
Collaborator

zhanglw0521 commented Jul 28, 2023

Sorry, I should have mentioned this earlier - so now we have an elementary version in this regard, which might be served as a starting point.

Edit: Maybe Jerry doesn't yet have access to this package, though?

@CheukHinHoJerry
Copy link
Collaborator Author

Ah yes - thanks for noticing this.

@CheukHinHoJerry
Copy link
Collaborator Author

I believe this is already implemented - I will close this now.

Ref ACEsuit/RepLieGroups.jl#7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants