-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symmetrization layer #42
Comments
I agree. RepLieGroups only needs to be assured that the basis transforms as expected. However, I'm not convinced that P4ML should depend on RepLieGroups. For now can we please work in a separate "drafting repo"? I will create that now. |
Just done a first draft on this and I will wait for the |
That repo is already ready. Just create a folder inside, eg call it jhh_ace1 with a Project and example script. |
We should think about how we can do the synmetrisation layer for real SH. Probably not hard, probably can be reduced to specifying the CG for rSH which should be a trivial linear transformation. |
@CheukHinHoJerry -- I talked to @zhanglw0521 about creating another package called |
Sorry, I should have mentioned this earlier - so now we have an elementary version in this regard, which might be served as a starting point. Edit: Maybe Jerry doesn't yet have access to this package, though? |
Ah yes - thanks for noticing this. |
I believe this is already implemented - I will close this now. |
I am doing that for single species case, after confirming it works fine I will then do that for multi-specices case.
A minor issue is that currently RepLieGroups is using P4ML so there is a circular dependency issue. However in RepLieGroups/src we do not need P4ML and we should remove that from deps.
The text was updated successfully, but these errors were encountered: