You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1352 move router handler methods to separate files, which makes it much more readable, but many of the new helper methods have an akka Context parameter and rely heavily on side-effects (publishing messages, notifications, replying to the sender referenced by the input context...).
It would be worth investigating if these methods can be made pure (for example return a new state and a series of action items). Sync handlers which are complex and rely on different types of side-effects could be a good starting point (see https://github.com/ACINQ/eclair/blob/master/eclair-core/src/main/scala/fr/acinq/eclair/router/Sync.scala)
The text was updated successfully, but these errors were encountered:
#1352 move router handler methods to separate files, which makes it much more readable, but many of the new helper methods have an akka
Context
parameter and rely heavily on side-effects (publishing messages, notifications, replying to thesender
referenced by the input context...).It would be worth investigating if these methods can be made pure (for example return a new state and a series of action items). Sync handlers which are complex and rely on different types of side-effects could be a good starting point (see https://github.com/ACINQ/eclair/blob/master/eclair-core/src/main/scala/fr/acinq/eclair/router/Sync.scala)
The text was updated successfully, but these errors were encountered: