Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cropped images to their own folder #709

Closed
SylviaWhittle opened this issue Oct 26, 2023 · 2 comments
Closed

Move cropped images to their own folder #709

SylviaWhittle opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@SylviaWhittle
Copy link
Collaborator

It has been requested that we have a "cropped_images" folder alongside the "processed" folder for easy access to molecule crops when image_set is set to all.

All the other file-specific images such as the cropped masks would stay where they are, this would just be for the actual cropped images, to allow for easy comparison of molecules in the whole dataset.

It was seemed insufficient to use a command such as:

mkdir ./cropped_grains; cp ./**/*_grain_image_*.png ./cropped_grains

due to the need for the default output to be simple and understandable for new users without having to use commands.

This should be a simple change, and perhaps could be a config setting, for example:

save_cropped_images_separately = True # Whether to save cropped images in their own folder or with all the other grain specific images.
@SylviaWhittle SylviaWhittle added the enhancement New feature or request label Oct 26, 2023
@SylviaWhittle SylviaWhittle self-assigned this Oct 26, 2023
@ns-rse
Copy link
Collaborator

ns-rse commented Oct 27, 2023

This looks like a duplicate of #702, could we close one or the other please?

I like the idea of making this configurable though. 👍

@SylviaWhittle
Copy link
Collaborator Author

Oops, sorry. I made this during a meeting and didn't realise Max already made one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants