Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopicMetadata API changes in rolling #34

Open
devrite opened this issue May 8, 2024 · 2 comments
Open

TopicMetadata API changes in rolling #34

devrite opened this issue May 8, 2024 · 2 comments

Comments

@devrite
Copy link
Contributor

devrite commented May 8, 2024

Rolling has changed the topic metadata info and added topic_id (returned by storage or upon creation), qos and other info.

See ros2/rosbag2#1538

They probably can be null initialized (need to check) but we need to adapt the code if possible maintaining backwards while hiding it from the user/dev somehow if they do not need or touch it.

@devrite
Copy link
Contributor Author

devrite commented May 8, 2024

Should be possible: https://docs.ros.org/en/rolling/Tutorials/Advanced/Recording-A-Bag-From-Your-Own-Node-Py.html#record-synthetic-data-from-a-node

        topic_info = rosbag2_py._storage.TopicMetadata(
            id=0,
            name='synthetic',
            type='example_interfaces/msg/Int32',
            serialization_format='cdr')
        self.writer.create_topic(topic_info)

@devrite
Copy link
Contributor Author

devrite commented Jul 16, 2024

Also see ros2/rosbag2#1648 for QoS changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant