Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting all Techradar data in every rendered HTML will eat up disk space with big radars #50

Closed
snipem opened this issue Jun 5, 2020 · 2 comments
Assignees

Comments

@snipem
Copy link

snipem commented Jun 5, 2020

We have a demo installation with about 200 items in the techradar. Putting every item and item description in every rendered html file of the techradar will easily eat up disk space. Currently this is done for initialising the Redux State Container in https://github.com/AOEpeople/aoe_technology_radar/blob/master/js/server.js#L51.

This is a concern with static page hosts like Github Pages or Gitlab Pages. The latter fails when pages exceed 100 MB.

We had a case where every rendered HTML file was about 500KB. With 200 items in the techradar the 100 MB max size was easily exceeded.

@bastianccm
Copy link
Member

Hi @snipem

Now the radar json is compiled into the assets, and the index.html is a much smaller entry point.
There was some refactoring, so you probably want to check out the changes.

Please see https://github.com/AOEpeople/aoe_technology_radar/#run-a-prepared-static-version for an example.

Currently (for our AOE techradar) we have ca. 2.6kb per html page. The radar data will be fetched afterwards. Hope this helps?

@bastianccm bastianccm reopened this Jan 11, 2021
@bmsuseluda
Copy link
Contributor

Hello @snipem we changed the loading of the json file, so that it will be fetched by the application. Therefore the browser can cache the file and the htmls don't have the data in itself.
I will close the issue. If you have problems with the current solution, let me know here and i can reopen the issue.

@bmsuseluda bmsuseluda self-assigned this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants