Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment to avifCheckItemID() about the source of the nonzero item_ID requirement #2476

Open
wantehchang opened this issue Oct 14, 2024 · 0 comments

Comments

@wantehchang
Copy link
Collaborator

@maryla-uc @vigneshvg @vrabaud @y-guyon FYI.

In src/read.c, the avifCheckItemID() function requires that the value of item_ID be nonzero. We should add a comment about the source of this requirement.

I am having trouble finding this requirement in ISOBMFF, HEIF, and MIAF. The closest thing I can find is the following paragraph in ISO/IEC 14496-12:2022 (ISOBMFF), Clause 8.11.1.1 on the definition of the MetaBox:

Derived specifications may further restrict the criteria for uniqueness: unique among the item_IDs in
both file and movie-level boxes, or unique within that set extended with the track_ID of the tracks in a
movie box. The item_ID value of 0 should not be used, and shall not be used when the set is extended to
include track_IDs.

But the last sentence uses "should not" in the initial, general part of the statement, and uses "shall not" only in the more specific part of the statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant