Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling issue with Microsoft SecurityInsight service #195

Open
ClementMindflow opened this issue Jan 18, 2022 · 2 comments
Open

Bundling issue with Microsoft SecurityInsight service #195

ClementMindflow opened this issue Jan 18, 2022 · 2 comments

Comments

@ClementMindflow
Copy link

ClementMindflow commented Jan 18, 2022

When bundling the Microsoft Azure Security Insight specification some resolved external references are invalid:

Here is the CloudError object definition inside this spec:

"CloudError": {
      "x-ms-external": true,
      "properties": {
        "error": {
          "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse",
          "description": "The error object of the CloudError response"
        }
      },
      "type": "object",
      "description": "An error response for a resource management request."
    }

I've double checked and the specified path is correct.

Here is the same object after bundling:

"CloudError": {
  "x-ms-external": true,
  "properties": {
    "error": {
      "$ref": "#/definitions/CloudError/properties/error/properties/details/items",
      "description": "The error object of the CloudError response"
    }
  },
  "type": "object", 
  "description": "An error response for a resource management request."
}

The new $ref is invalid as there is no details property within that object and the ErrorResponse does not appear in the bundled file.

I'm using @apidevtools/swagger-parser 10.0.3

And here are the options passed when bundling:

SwaggerParser.bundle(inputFile, {
    validate: {
      spec: false,
      schema: false,
    },
  })
@fab-mindflow
Copy link

Hey, any hint on how to fix this?

@ClementMindflow
Copy link
Author

Does anyone already faced that issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants