Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TARGET_NRF5] serial_api.c doesn't seem to support a platform which CTS pin are not used #2474

Closed
ytsuboi opened this issue Aug 17, 2016 · 9 comments

Comments

@ytsuboi
Copy link
Contributor

ytsuboi commented Aug 17, 2016

Problem

The TY51822R3 platform use nRF51822 (Rev.3) device and CTS/RTS signals are not connected to the mbed interface chip on this platform.
When printf() function is called by mbed program, the program hangs most of time.

Thoughts

I am investing this problem now. But the code in TARGET_NRF5/erial_api.c assumes flow control by CTS/RTS. It should take care about non flow control platform as well.

@ytsuboi ytsuboi changed the title [TARGET_NRF5] serial_api.c looks not async even if there are DEVICE_SERIAL_ASYNCH=1 macro [TARGET_NRF5] serial_api.c doesn't seem to support a platform which CTS pin are not used Aug 17, 2016
@ytsuboi
Copy link
Contributor Author

ytsuboi commented Aug 17, 2016

Patched. Now, printf() works fine on TY51822r3. Still need to test on nRF51-DK.
ytsuboi@0b79028

Can I make a pull request after testing with nRF51-DK? @anangl @0xc0170

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Aug 18, 2016

PR made. #2482

@nuket
Copy link
Contributor

nuket commented Aug 18, 2016

This hang is also biting me hard on the nRF51-DK.

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Aug 19, 2016

#2489

@sg-
Copy link
Contributor

sg- commented Aug 25, 2016

Can you confirm is #2535 resolved this issue?

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Aug 26, 2016

PR made #2555

@nvlsianpu
Copy link
Contributor

@ytsuboi Could you close this issue?

@ytsuboi
Copy link
Contributor Author

ytsuboi commented Aug 30, 2016

Solved! @nvlsianpu

@ytsuboi ytsuboi closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants