-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmsis5/rtx2 nrf51: RTX SysTick API needs updating #3690
Comments
@bulislaw Is it possible to have documentation ? I don't see which function have to be called by the tick generator. Is it osRtxTick_Handler ? |
There's no documentation in CMSIS5 repo I could find. But as far as i understand 'no function' is called, you just need to rise irq which number you return from |
Looking at the assembly code, the expectations are a bit different as well. Previously it was just suppose to call the tick handler, now it should call also call To have help from Nordic engineers it would be better to have a porting guide like for RTX v1. Could we ask this to the RTX team ? |
cc @ReinhardKeil @RobertRostohar - please have a look at this issue |
@bulislaw From my understanding: /**
* Setup timer (including IRQ priority) and return IRQ number.
* Was previously int os_tick_init (void)
*/
int32_t osRtxSysTimerSetup (void);
/**
* Acknowledge IRQ
* Was: void os_tick_irqack(void)
*/
void osRtxSysTimerAckIRQ (void); //
/**
* Current Tick count (32-bit)
* was uint32_t os_tick_val(void)
*/
uint32_t osRtxSysTimerGetCount(void);
// These three functions are new functions specific to RTX v2 and have to be implemented
uint32_t osRtxSysTimerGetFreq (void); // Timer Tick frequency
void osRtxSysTimerEnable (void); // Start timer
void osRtxSysTimerDisable (void); // Stop timer
// The function os_tick_ovf is deprecated ... The function Do we have the same understanding ? |
From the email exchange:
|
@nvlsianpu @anangl Do you think you can look at this item ? I can help you in the process. |
On the first sight it's look like nRF51 targets are touched. nRF52 has and using SysTick for RTX. |
I made PR #3769 (preview as far). I can't to build NRF51_DK target due to errors form base branch. Could you resolve these errors? |
@nvlsianpu Could you detail the issue you encounter when you build for the NRF51_DK (compiler, commit id, etc) ? |
GCC_RM, SHA-1: 942bad4
|
@nvlsianpu with current
could you have a look at the failing tests please |
ack |
I'm getting all green for NRF52, but back to issues on for NRF51:
for gcc 5.4, I'll run ARM tomorrow. |
All test are passing on feature_cmsis5 branch. Closing. |
Description
Bug
Target
nrf51_dk (but most likely all Nordic platforms requiring non standard systick)
We're trying to finalize CMSIS5/RTX2 (https://github.com/ARMmbed/mbed-os/tree/feature_cmsis5) update in next month, but we're having issues with Nordic platform. When executing tests (eg
mbed test -n tests-mbedmicro-rtos-mbed-basic -m nrf51_dk -vv
) I'm getting a timeout. That's most likely due to changes in RTX API (https://github.com/ARMmbed/mbed-os/blob/feature_cmsis5/rtos/rtx2/TARGET_CORTEX_M/rtx_system.c#L212) Nordic HAL SysTick override needs to be updated (and validated) for CMSIS5/RTX2.@pan- Can we ask Nordic guys to help us with the update? I'd rather have someone that knows the platform doing that as it's not enough just to rename the functions.
The text was updated successfully, but these errors were encountered: