Set datetime time zone if TZID propery present #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h event TZID property
|
Can you re-document with devtools::document()so checks pass? |
|
You can check locally with devtools::check()Looking great btw. |
|
We're getting an error message in the examples now @silverfoxdoc, any ideas? https://github.com/ATFutures/calendar/actions/runs/8902573330/job/24448742581#step:6:170 |
|
looks like trying to add this feature has broken the ability to write an ical object out to .ics file; I don't have a lot of time spare at present but hopefully might be able to come back to this in a about a month or so |
|
OK, thanks @silverfoxdoc and no worries. I'm confident this is a + for the package so will also aim to take a look when time allows 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on this a while ago and came back to this in the last few days with newed enthusiasm.
I noticed that calendars which have TZID property (apple calendar and I think outlook as well) were not being allocated to the stated TZID property time zone.
Needed to do some more reading to improve my base R code knowledge but think I've sorted it now to allocate TZID property time zone and then convert to local time zone.
I have extracted each TZID property timezone individually for each column and then mapped it to same columns; I don't think most calendar software will allow different timezones to be set for different events within same calendar but I noticed when testing that if you do that, you get multiple DTSTART/DTEND columns with the different TZID properties so this would hopefully future proof it so to speak. It wouldn't merge them but into single column but user could probably do that themselves if desired.
See what you think and if it should be included.