Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: $GIT seems not to be used at all places where sources are updated at start #12132

Closed
1 task done
allo- opened this issue Jul 28, 2023 · 1 comment
Closed
1 task done
Labels
asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance

Comments

@allo-
Copy link

allo- commented Jul 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

When launching the webui offline, it hangs as it tries to update certain components. By setting GIT=/bin/true one can skip many of the updates but not all

Steps to reproduce the problem

  1. Have no internet connection
  2. launch GIT=/bin/true ./webui.sh
  3. Installation of requirements is skipped (i.e. /bin/true pull ... is called), but it seems that git_clone calls are not skipped.

What should have happened?

All Places should use $GIT in python using os.environment

Version or Commit where the problem happens

68f336b

What Python version are you running on ?

Python 3.10.x

What platforms do you use to access the UI ?

Linux

What device are you running WebUI on?

Nvidia GPUs (RTX 20 above)

Cross attention optimization

xformers

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--xformers --medvram

Console logs

...
################################################################
Launching launch.py...
################################################################
Using TCMalloc: libtcmalloc_minimal.so.4
Python 3.10.12 (main, Jun  7 2023, 10:09:46) [GCC 12.2.0]
Version: v1.5.1
Commit hash: 68f336bd994bed5442ad95bad6b6ad5564a5409a





Launching Web UI with arguments: --medvram --xformers

Additional information

Comment #1523 (comment) would probably be a workaround. Allowing git and pip to be replaced by /bin/true through environment variables would avoid the need to patch source code.

@allo- allo- added the bug-report Report of a bug, yet to be confirmed label Jul 28, 2023
@catboxanon
Copy link
Collaborator

catboxanon commented Aug 7, 2023

It should already be doing this for git.

git = os.environ.get('GIT', "git")

# git executable
if [[ -z "${GIT}" ]]
then
export GIT="git"
fi

I'm not so sure about pip. Almost all calls to pip look to be done through the Python executable.

@catboxanon catboxanon added asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance and removed bug-report Report of a bug, yet to be confirmed labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance
Projects
None yet
Development

No branches or pull requests

2 participants