Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Added notification sound #16664

Open
1 task done
hackedpassword opened this issue Nov 18, 2024 · 3 comments
Open
1 task done

[Feature Request]: Added notification sound #16664

hackedpassword opened this issue Nov 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@hackedpassword
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Not do, does. Not sending up as a pull request, more fyi if anyone wants the feature and how to do it.

Does:
Upon completion of image generation, or, completion of loading a checkpoint, make a notification sound.

Proposed workflow

shared_total_tqdm.py:

import winsound
...
line 36 +
            sound_file = "C:\\Windows\\Media\\notify.wav"  # Path to the sound file
            winsound.PlaySound(sound_file, winsound.SND_FILENAME)

sd_models.py:
same as above, + line 348 after
timer.record("load weights from disk")

Additional information

That little notification sound is a very small but huge QoL improvement, imo. Merge if you like/want/whatever.

@hackedpassword hackedpassword added the enhancement New feature or request label Nov 18, 2024
@w-e-w
Copy link
Collaborator

w-e-w commented Nov 19, 2024

we actually have notification sound https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#notificationmp3
but the way that it is currently implemented it ONLY works on txt2img tab

as in it dose not work on img2img or any other tabs

it should be a simple matter to extend it to other tabs


btw your proposed solution won't really work if you are using a remote server to run webui

@hackedpassword
Copy link
Author

Ah, no idea about that, only used locally but makes sense.

@hackedpassword
Copy link
Author

@w-e-w I'm reading through the wiki - hadn't actually seen this before, been generally working through trial and error figuring out a1111 organically. Thanks for sharing that link! Already patched several knowledge holes in some of the behind the scenes magic. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants