Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.11 is incorrectly versioned and will make and install an incorrect cmake find package #409

Open
jamesrburgess opened this issue Jun 30, 2024 · 1 comment

Comments

@jamesrburgess
Copy link

Hi,
This commit 7bc6097 titled "Bump version for v3.1.11" suspiciously only changes IMATH_LIBTOOL_REVISION from 9 to 10. Not sure what "10" is supposed to signify but I digress. The issue is that a few lines up in CMakeLists.txt we have:

# Imath version
project(Imath VERSION 3.1.10 LANGUAGES C CXX)

This is also in the signed tarball artifacts.

The installed ImathConfig.cmake will wind up with:

set(PACKAGE_VERSION "3.1.10")
@cary-ilm
Copy link
Member

cary-ilm commented Aug 1, 2024

Yikes! Apologies for missing this. That was clearly a typo. New release coming shortly. Thanks for the catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants