-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed implementation of succ and pred to use std::nextafter. #353
Changed implementation of succ and pred to use std::nextafter. #353
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks, this preserves the existing edge case behavior, which seems appropriate. The ASWF requires "signed" commits, which is why the DCO check failed. Can you amend your commit? Do this:
That adds a line to the message certifying that the change originated with you. |
Signed-off-by: Jean-Marie Aubry <[email protected]>
4d58d77
to
573d1ee
Compare
Done. I think the CI is still waiting approval? |
Nice simplification |
…mySoftwareFoundation#353) Signed-off-by: Jean-Marie Aubry <[email protected]>
…mySoftwareFoundation#353) Signed-off-by: Jean-Marie Aubry <[email protected]>
Signed-off-by: Jean-Marie Aubry <[email protected]>
## Version 3.1.10 (January 26, 2024) Patch release with various build/bug fixes. Build fixes: - Fix a problem where downstream projects using Imath would build python bindings even if they weren't requested. - Fix for missing `std::bit_cast` - Fix missing/necessary use of IMATH_HOSTDEVICE - IMATH_INSTALL_PKG_CONFIG is now on by default, even on Windows - Fix calling default constructor by uniform init in TypeTraits - Fix redundant PYIMATH_EXPORTS causing compile issues on Windows Clang - Update to SO versioning policy: This change adopts a policy of appending the ``MAJOR.MINOR.PATCH`` software release name to the ``SONAME`` to form the real name of the shared library. See [website/install.rst](website/install.rst) and [PR #339](AcademySoftwareFoundation/openexr#339) for more details. Bug fixes: - Fix half to float giving wrong results on older x86_64 CPUs on Windows Other changes: - succ()/pred() now use std::nextafter(). - Expand epsilon bounds for m44x pyImath test. - Rename "docs" to "website". - Add missing copyright/license identifiers. ### Merged Pull Requests * \[[#363](AcademySoftwareFoundation/Imath#363] Update install instructions to reflect new SO versioning policy * \[[#362](AcademySoftwareFoundation/Imath#362] Require sphinx 5.0 * \[[#361](AcademySoftwareFoundation/Imath#361] src/python/config/ModuleDefine.cmake: do not install a cmake file exporting targets for dependent projects * \[[#358](AcademySoftwareFoundation/Imath#358] Fix half to float giving wrong results on older x86_64 CPUs on Windows * \[[#353](AcademySoftwareFoundation/Imath#353] Changed implementation of succ and pred to use std::nextafter. * \[[#350](AcademySoftwareFoundation/Imath#350] Fix check for the availability of std::bit_cast * \[[#349](AcademySoftwareFoundation/Imath#349] IMATH_INSTALL_PKG_CONFIG is on by default, even on Windows * \[[#347](AcademySoftwareFoundation/Imath#347] Export Imath from the build tree and so on. * \[[#344](AcademySoftwareFoundation/Imath#344] rm unnecessary IMATH_HOSTDEVICE attributes. * \[[#342](AcademySoftwareFoundation/Imath#342] Add missing copyright/license identifiers * \[[#341](AcademySoftwareFoundation/Imath#341] Remove unnecessary files * \[[#340](AcademySoftwareFoundation/Imath#340] Fix calling default constructor by uniform init. * \[[#339](AcademySoftwareFoundation/Imath#339] Update and simply SO versioning policy * \[[#338](AcademySoftwareFoundation/Imath#338] Rename "docs" to "website" * \[[#333](AcademySoftwareFoundation/Imath#333] Expand epsilon bounds for m44x pyImath test * \[[#331](AcademySoftwareFoundation/Imath#331] Fixed redundant PYIMATH_EXPORTS causing compile issues on Windows Clang * \[[#326](AcademySoftwareFoundation/Imath#326] Use [email protected] for consistency * \[[#320](AcademySoftwareFoundation/Imath#320] Add missing IMATH_HOSTDEVICE to Matrix33<T>::invert(bool)
Hey. I didn't really deprecate them because there is no 1:1 equivalent in std. Instead I replaced the implementation to use std::nextafter. All tests pass.