Support for Python 3.10? #1224
Comments
|
Your Shot Manager project looks very cool! If I'm not mistaken, your team is building OpenTimelineIO locally, rather than using a wheel. Is that correct? I notice also in your FAQ that it says you are working on getting a Mac build of OTIO working for Python 3.9. (https://ubisoft-shotmanager.readthedocs.io/en/latest/troubleshoot/faq.html) I did a test build just now on Mac M1, with Python 3.10, and didn't encounter a problem Perhaps the thing to do is to list the issues you are encountering here to work through, and if any of them require extra attention, new issues could be opened to track them individually? |
|
Hi Meshula, In fact we are not building our wheel anymore. We did that for OTIO 0.12 cause we had a fix to do somewhere (I don't remember what, it was made by a developer of the team at the time) and for OTIO 0.13 cause there was no wheel for Python 3.9 when Blender moved to it. I also had to drop off the wheel for Mac cause I have no practical means to test it (no Mac :D ) I am not so much at ease myself with the versions of Python and libraries and wheels. What I know though is that installing OTIO thanks to PIP is pretty handful and when there is no version that suits the Python version of Blender things become quickly complicated. |
|
@JeanChristopheMorinPerso, @reinecke ~ do you have any notes to share in this thread on what's necessary for automation around Python 3.10 OTIO wheels? |
|
The best notes are going to be when I added Python 3.9 support I think, see https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/1080/files for anyone interested in contributing. As for Mac M1, that's a different story. I left some notes in #1214. So all in all, adding 3.10 support should be a straight forward task for anyone interested in contributing. I'd like to do it but I have limited bandwidth right now. |
|
And for the curious, I've been running OTIO with Python 3.10 for a while now (locally) and I haven't hit any issues, at least on Linux. |
|
This is the error I get when installing opentimelineio under shotmanager addon with Blender 3.2 and 3.1 which is using python 3.10
ERROR: Failed building wheel for opentimelineio |
|
Hello Gattung, thanks for the details. The cmake error indicates that the Python headers and libraries corresponding to the Python libraries in your copy of Blender are not being detected. The one thing I recall from others' experiences in building OTIO with Blender is that if you can set up the build such that cmake can find corresponding headers and libraries, the build will succeed. Unfortunately the Blender build environment is not one I am that familiar with. Perhaps someone has details on how to set this up, or better recollection than I on solving this issue. If I remember, people have built OTIO separately into a standard Python environment corresponding to Blender's python version, then manually moved it into Blender's site-packages area. |
|
Hi @Gattung, I'm currently working on both topics and a new release of Shot Manager should be release next week. So stay tuned ;) |
|
@JeanChristopheMorinPerso Hi Jean-Christophe, Thank you On 0.14: And on 0.15: |
|
I see the same thing. |
|
The |
|
No problems reported: ╰─ pip install .
Processing /private/var/tmp/opentimelineio-umbrella/OpenTimelineIO-mirror
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: pyaaf2~=1.4.0 in /Library/Application Support/xxx/x86_64_python3_pyside6/lib/python3.10/site-packages (from OpenTimelineIO==0.15.0.dev1) (1.4.0)
Building wheels for collected packages: OpenTimelineIO
Building wheel for OpenTimelineIO (pyproject.toml) ... done
Created wheel for OpenTimelineIO: filename=OpenTimelineIO-0.15.0.dev1-cp310-cp310-macosx_11_0_x86_64.whl size=1283726 sha256=26227cdee0e5c5bd224dc21ee53b58e54847632c36c3472d9bb40a6f5c7dff70
Stored in directory: /Users/nporcino/Library/Caches/pip/wheels/01/01/6a/03aaf6d7c7ab02f2210238e97022fb025deaf14bb9d4e1723a
Successfully built OpenTimelineIO
Installing collected packages: OpenTimelineIO
Successfully installed OpenTimelineIO-0.15.0.dev1 |
|
Looks like that bit of setup.py is not running. |
|
#1238 is the culprit I think. |
|
Thank you. I will try again once this merge request is merged. |
|
@werwack You can open a Pull Request that targets the master branch, and a 0.14.2 release could be made if the TSC determines it's the way to go. So what's important is to first create a pull request so the process/discussions can be started. |
|
Oh, and maybe it wasn't clear, but the issue you found @werwack is not specific to Python 3.10. The issue should affects all python versions. |
|
I created a PR and it got merged in master. Anyone interested can test the generated wheels by going to https://github.com/PixarAnimationStudios/OpenTimelineIO/actions/runs/2046354939 while being logged in, and download the |
|
Hi @JeanChristopheMorinPerso, |
|
Pushing to PyPI will require a release, which is out of my control. The best I can do is to tag the TSC members (@meshula, @jminor, @ssteinbach and @reinecke) and and ask if this can be added to the agenda of the next TSC meeting, scheduled on March 31 at 1pm EDT (see https://lists.aswf.io/g/otio-discussion/viewevent?repeatid=17408&eventid=1448520&calstart=2022-03-31 for more details). |
|
@JeanChristopheMorinPerso Unfortunately I won't we available to attend to the meeting this Thursday, but I would appreciated if the push on PyPi could be discussed. |
|
@werwack With regards to fcp xml issue, the request is out for someone who can test the fix to submit a PR. It does seem straight forward, but needs someone familiar with the problem to give it a shot and verify that a fix works. We can raise it at the tsc. |
Just wanted to add that this method works well for me with Blender 3.1. Compiles and installs as expected. |
|
Hi Daniel, Nick, Jean-Christophe, I just posted a message saying that I still had the issue of the "__version__" information on the wheels but after some more check this was a wrong setting on my side, so ignore this previous message if you see it. @danielskovli Thank you very much for the test on Blender. I've integrated the wheels related to Python 3.10, for each plateform, on the latest version of Ubisoft Shot Manager, my add-on for Blender. Works on Win64, cannot test on Mac nor on Linux but finger crossed ;) Best regards, |
Feature Request
Is this a New Feature, or a Proposed Change to existing Behavior?
This is the continuity of existing feature.
Description
Describe the new feature, or describe the modification to existing behavior, and provide context as necessary to help with understanding how the feature relates to a workflow or functionality.
I am the developer of Shot Manager, a Blender add-on that provides many features to manipulate shots in the 3D space of Blender but also to import and export edits with other software. To do so I rely on OpenTimelineIO.
Thing is Blender is changing regularly (or irregularly I should say) the version of Python they support, this in order to stick to the latest version. An in March Blender 3.1 will be on Python 3.10.
Would it be possible to have a version of OTIO for Python 3.10? That would be of a great help!
Thank you
The text was updated successfully, but these errors were encountered: