Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API: should double type/[up|down]grade function registration raise an exception #1391

Open
2 tasks
ssteinbach opened this issue Sep 10, 2022 · 0 comments

Comments

@ssteinbach
Copy link
Collaborator

Following discussion from: #1387

The python binding for the registration system for types and up/downgrade functions currently returns a bool:

However, the bindings have a system for capturing these results and raising exceptions. I briefly experimented with this during the development of #1387, but it seems like the python unit tests assume that its ok to double register the same type without it triggering an exception.

For unit testing this probably means additional functions that allow un-registering types from the TypeRegistry.

I think the action items are:

  • discuss at a TSC meeting whether this would be desired behavior,
    • ...and if so what exception should be raised
@ssteinbach ssteinbach added the bug A problem, flaw, or broken functionality. label Sep 10, 2022
@ssteinbach ssteinbach added needs discussion and removed bug A problem, flaw, or broken functionality. labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant