Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Header attribute iterator methods #1554

Closed
cary-ilm opened this issue Sep 11, 2023 · 4 comments
Closed

Add tests for Header attribute iterator methods #1554

cary-ilm opened this issue Sep 11, 2023 · 4 comments
Labels
good first issue Possible one-day project for somebody new

Comments

@cary-ilm
Copy link
Member

cary-ilm commented Sep 11, 2023

Add tests to the test suite for the Header classes attribute iterator methods in src/lib/OpenEXR/ImfHeader.h.

The coverage report that identifies the uncovered lines is here

The tests should go in src/test/OpenEXRTest and follow the established pattern.

@cary-ilm cary-ilm added the good first issue Possible one-day project for somebody new label Sep 11, 2023
@MrGlobby
Copy link
Contributor

Hi @cary-ilm! I was planning to do this for the ASWF dev days, but I can't see anything in the linked coverage report that highlights uncovered lines in ImfHeader.h. I can see such highlighting in other files, so I'm not sure what I'm missing?

@cary-ilm
Copy link
Member Author

@MrGlobby the SonarCloud coverage report is sort of finicky and often confusing. In this case, I think I meant to post a link to the ImfHeader.cpp file. The non-const begin() and end() methods appear to not get invoked.

The low-tech approach is to put a print statement in the functions, then execute the test suite to confirm the message doesn't appear, then add the call to the test suite, rerun it and confirm the message appears. Then remove the print statement.

Of course, feel free to browse the SonarCloud coverage report and add anything else you see uncovered, this one just looked pretty straightforward.

@MrGlobby
Copy link
Contributor

I've made a pull request for this, hope I've done it correctly! #1577

@cary-ilm
Copy link
Member Author

cary-ilm commented Mar 7, 2024

done, thanks.

@cary-ilm cary-ilm closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Possible one-day project for somebody new
Projects
None yet
Development

No branches or pull requests

2 participants