Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: launching on tray icon doesn't check for existing tabs or PWA #1063

Open
2 tasks done
PetbkA opened this issue May 30, 2024 · 0 comments
Open
2 tasks done

[UI]: launching on tray icon doesn't check for existing tabs or PWA #1063

PetbkA opened this issue May 30, 2024 · 0 comments

Comments

@PetbkA
Copy link

PetbkA commented May 30, 2024

  • I am on the latest beta v0.12.3b19 ActivityWatch version.
  • I have searched the issues of this repo and believe that this is not a duplicate.

Describe the bug

As being seen in browser's omnibox, AW supports turning into Progressive Web App.

The problem is that the tray icon can't open AW as PWA - it still opens it as browser tab, whether PWA or browser tab has been already opened or not.

The same with browser tabs - double-clicking tray icon always opens new AW tab, even if it's tab has been already opened.

To Reproduce

  1. Open any of AW's pages;
  2. Double-click AW's tray icon: NOK - new AW browser tab opens instead of activating existing one;
  3. Leave one AW tab (close others) and install it's PWA;
  4. Double-click AW's tray icon: NOK - AW PWA window isn't being activated, and new browser tab opens instead;
  5. Close AW's PWA and all it's browser tab and repeat step 2: NOK - AW still opens in new browser tab.

Expected behavior

I suggest the following behavior on double-clicking AW tray icon:

PWA installed AW tab opened PWA launched Action
- - - New browser tab will be opened
- + - Browser tab will be activated. If there are several opened tabs, the latter will be activated
+ - - PWA will be launched
+ + - Browser tab will be activated. If there are several opened tabs, the latter will be activated
+ - + PWA window will be activated
+ + + PWA window will be activated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant