Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options are incorrectly displayed when "long link" is blocked #250

Open
AdamWr opened this issue Sep 22, 2021 · 4 comments
Open

Options are incorrectly displayed when "long link" is blocked #250

AdamWr opened this issue Sep 22, 2021 · 4 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Sep 22, 2021

Steps to reproduce:

  1. For example, add this rule to user filter:
example.org#%#AG_onLoad(function() { document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(500)}`)) });

or run this code in console (after step 2):

document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(500)}`))
  1. Go to - https://example.org/
  2. Click somewhere
  3. Popup should be blocked
  4. Click on "Options" button
Screenshot - some options are not visible

image

It should looks like that:

Screenshot

image

AdGuard Popup Blocker (Beta) 2.5.56

@ghost
Copy link

ghost commented May 3, 2024

I have the same problem as above.

@stanislav-atr
Copy link
Contributor

@NightmareWyrm, hi! This is not reproducible on my side, could you please specify the website and steps to reproduce this?

@AdamWr, could you please confirm that this issue is fixed?

@AdamWr
Copy link
Member Author

AdamWr commented May 8, 2024

Unfortunately, I still can reproduce it with version 2.5.94.
As far as I understand, the problem is that the blocked link doesn't fit on the screen, because is too long.
If I change repeat(500) to for example repeat(450) (in the script from the first post) then it's fine.
@stanislav-atr Could you please try to change it to something like repeat(50000):

document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(50000)}`))

and then check again?

@ghost
Copy link

ghost commented May 8, 2024

@NightmareWyrm, hi! This is not reproducible on my side, could you please specify the website and steps to reproduce this?

Go to this link: https://totalsportek.pro/game/real-madrid-vs-bayern-munchen/26987/
Click above the video player and below the live stream multiple times to trigger popup

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants