Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: New checkbox component to replace iCheck dependency #700

Closed
1 of 2 tasks
ChaoLiangSuper opened this issue Feb 22, 2018 · 8 comments · Fixed by #723
Closed
1 of 2 tasks

Proposal: New checkbox component to replace iCheck dependency #700

ChaoLiangSuper opened this issue Feb 22, 2018 · 8 comments · Fixed by #723
Assignees

Comments

@ChaoLiangSuper
Copy link
Contributor

ChaoLiangSuper commented Feb 22, 2018

The iCheck lib is out of date and not been updated for months. So, we might need our own checkbox component.

Types of issue

Description

  • Build a new checkbox component
  • Remove the old dependency

screen shot 2018-04-19 at 14 44 56

@lightbringer1991
Copy link
Contributor

if it is not so much different than iCheck, we can fork the library and maintain it ourselves (e.g. fixing bugs or implement new logic), without having to reinvent the wheel.

@ChaoLiangSuper
Copy link
Contributor Author

@lightbringer1991 Sorry for the late update, I didn't get the notification for your comment 😂. I think to redo the icheck component because we can also reduce the size of our project. For instance, those themes in icheck we don't need them.

@omgaz
Copy link
Contributor

omgaz commented Apr 19, 2018

Some things to consider

  • Should try to support a painless migration from iCheck.
  • Should support radio and checkbox (returning a single value).
  • Should support checkbox groups (returning an array or key/values).
  • Should support radio groups (validating only one is selected).
  • Should support labels.
  • Should support disabled state.
  • Should accept custom classes
  • Should accept data-test-selector attribute
  • Should accept onChange methdod
  • Should not support themes or style customisations.

Follow-up PR:

  • Should support NEW functionality of a tri-state.

@ChaoLiangSuper
Copy link
Contributor Author

PR got merged. Closing this issue.

@omgaz omgaz reopened this May 28, 2018
@omgaz
Copy link
Contributor

omgaz commented May 28, 2018

This issue is not yet resolved, the radios have not yet been implemented as part of this issue - it's only halfway there.

@lightbringer1991
Copy link
Contributor

if @nimishjha is busy with something else, I can give it a try on Radio buttons.

@lightbringer1991
Copy link
Contributor

reopen since icheck has not been removed yet.

@ChaoLiangSuper
Copy link
Contributor Author

Closing this issue and open another issue for removing the iCheck lib.
#727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants