Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Get3dsAvailability into BinLookup directory #103

Merged
merged 14 commits into from
Mar 13, 2019

Conversation

fabricioblz
Copy link
Contributor

Description
In order to make it possible to call /get3dsAvailability.
This PR make this possible via SDK

Usage

        $json = '{
          "cardNumber": "4212345678901245",
          "merchantAccount": "TestMerchant"
        }';

        $params = json_decode($json, true);
        $service = new \Adyen\Service\BinLookup($this->apiClient)

        return json_encode($service->get3dsAvailability($params));

@Aleffio
Copy link
Member

Aleffio commented Feb 27, 2019

Hi @fabricioblz

Thank you for the PR!
We are going to review it and merge it.

Kind Regards,
Alessio,
Adyen

@fabricioblz
Copy link
Contributor Author

Thank you for the review.

I've made the modifications. Could you check please?

@fabricioblz
Copy link
Contributor Author

No worries, I commited your change = )

@fabricioblz
Copy link
Contributor Author

fabricioblz commented Feb 28, 2019

Now is everything all right?

Let me know in case of any additional change.

@rikterbeek
Copy link
Contributor

Hi @fabricioblz,

Thanks for the PR looks great. Are you able to add a test case for this as well ?

Regards,
Rik
Adyen

Fabricio Bellesa added 2 commits March 8, 2019 16:29
@fabricioblz
Copy link
Contributor Author

Sure @rikterbeek,

I've made two basic tests:

@fabricioblz
Copy link
Contributor Author

Is there something else that can I adjust?

@cyattilakiss cyattilakiss merged commit 93e14be into Adyen:develop Mar 13, 2019
@cyattilakiss
Copy link
Contributor

Hi @fabricioblz ,
We are going to release your changes in the next library release. Thank you for your contribution.
Best,
Attila
Adyen

@fabricioblz
Copy link
Contributor Author

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants