Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer.lock #134

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Add composer.lock #134

merged 1 commit into from
Nov 19, 2019

Conversation

msilvagarcia
Copy link
Contributor

This standardizes the versions of libraries used.

This standardizes the versions of libraries used.
@rikterbeek
Copy link
Contributor

@msilvagarcia what is the benefit of this ?

@msilvagarcia
Copy link
Contributor Author

@rikterbeek From the composer documentation:

Committing this file to [Version Control] is important because it will cause anyone who sets up the project to use the exact same versions of the dependencies that you are using. Your [Continuous Integration] server, production machines, other developers in your team, everything and everyone runs on the same dependencies, which mitigates the potential for bugs affecting only some parts of the deployments. Even if you develop alone, in six months when reinstalling the project you can feel confident the dependencies installed are still working even if your dependencies released many new versions since then.

I think it's a nice safe-guard to have in place. Might prevent some headaches.

@cyattilakiss cyattilakiss merged commit 40daaa9 into develop Nov 19, 2019
@cyattilakiss cyattilakiss deleted the add-composer-lock branch November 19, 2019 12:09
@cyattilakiss cyattilakiss mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants