Release 6.0.0 #171
Merged
Release 6.0.0 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CODEOWNERS
Fix bad phpdoc typehint for $liveEndpointUrlPrefix argument
This automates the `vagrant up` command by provisioning required packages and dependencies, and installing them on a provisioning run. The `bin/composer-installer.sh` file is a recommended automation found in getcomposer.org. It downloads the sha-key for validation from the GitHub repository and downloads the composer.phar from the main location. This ensures a more secure download.
So that we don't forget to check if our changes break work that has been done before, this commit adds configuration to: 1. Run PHPUnit on commits and/or Pull Requests 2. Run the PHP syntax checker (`php -L`) on the project files This Pull Request will also: 1. Bump up the PHPUnit version 2. Add basic code coverage documentation\ 3. Update Vagrantfile with XDebug to generate such documentation 4. Update .gitignore to accommodate for new auto-generated files
To help us with code standards, this adds PHP Code Sniffer to the project. It also fixes the errors found while running it in the command line and enables it in Travis.
While the documentation says that you need to escape the data before doing an HMAC calculation for notifications, this is currently not happening. This commit will work around that until the issue is fixed.
PHP 7.4 was released in December. This raises awareness on compatibility issues.
The /vagrant folder is write-protected in CentOS. This configuration prevents PHPStorm of trying to access it to run tests or other configuration.
* Add maskParametersRecursive() to mask all the sensitive parameters Walk through recursively in an associative array containing all the key path combinations for the sensitive values in the request or response parameters array Masking is only effective in live environment Add maskParameter() to only keep the first 10 characters of the parameter's value and append 3 asterisks in case the value is not empty * Use maskParametersRecursive() in logRequest() to mask parameters Add parameter list that needs to be masked Add environment as a required parameter to the logRequest() to determine if masking needs to be done or not Masking only needs to be done in live environment Adjust the existing usage of the logRequest to the new parameters list * Add logResponse() to log response objects Replace the current response object logging with logResponse() * Add getEnvironment() to retrieve the config environment value * fix logResponse() and logRequest() Json decode response before logging because the logResponse expects and array Add paymentData into the list of $paramsToMask for both request and response logging * Change maskParameter() to mask short parameters completely * Add environment as a parameter into the createMockClient() To be able to mock not just test but live configurations as well * Replace testAuthoriseSuccess with testAuthoriseSuccessInTestEnvironment By default in test environment the library will not mask the parameters only in live environment * Add testAuthoriseSuccessInLiveEnvironment() to test authorize in live In live environment the parameters will be masked * Resolve pull request comments Make $paramsToMask in response and $paramsToMask in request to a private static property * Switch maskParameter() from 10 char to 6 char value length
…notification configuraiton for marketpay has a breaking change as you get different result fields for certain actions. (#162)
While the documentation says that you need to escape the data before doing an HMAC calculation for notifications, this is currently not happening. This commit will work around that until the issue is fixed.
msilvagarcia
requested review from
Aleffio,
AlexandrosMor,
cyattilakiss and
rikterbeek
as code owners
cyattilakiss
previously approved these changes
Feb 13, 2020
cyattilakiss
previously approved these changes
Feb 14, 2020
Aleffio
reviewed
Feb 14, 2020
|
@Aleffio while I believe your suggestions are great, I don't think this Pull Request is the best place to apply them. This would mean we're pushing commits to the develop branch, which should only be done with Pull Requests. Do you think I should open a new pull request for these changes? |
|
@msilvagarcia I agree this is not the best place, though this review is like a "second chance" of seeing something before it goes to the master branch. I don't believe these suggestions are so complex to need a separate pull request, but feel free to open one if you think it is needed |
rikterbeek
previously approved these changes
Feb 16, 2020
Aleffio
dismissed stale reviews from rikterbeek and cyattilakiss
via
2294fa7
Aleffio
approved these changes
Feb 17, 2020
cyattilakiss
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This releases version 6.0.0 of the Adyen PHP API Library
Remarkable features include:
Because of the update to the latest API version (#162), this is a major release. There are changes to the MarketPay configuration API responses that users need to address after updating.