PW-421: Adding Checkout and Checkout Utility support, modified CurlCl… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient to make it testable
lancergr
reviewed
May 4, 2018
src/Adyen/Service/Checkout.php
Outdated
| $this->_paymentMethods = new \Adyen\Service\ResourceModel\Checkout\PaymentMethods($this); | ||
| $this->_payments = new \Adyen\Service\ResourceModel\Checkout\Payments($this); | ||
| $this->_paymentsDetails = new \Adyen\Service\ResourceModel\Checkout\PaymentsDetails($this); | ||
| $this->_supportsXAPIKey = true; |
There was a problem hiding this comment.
now that the pal is accepting apiKey, we should better change it to "requiresApiKey".
Preferably bring another \Adyen\Service subclass (eg. ApiKeyAuthenticatedService) that has it set by default and let Checkout extending the new service class
rikterbeek
reviewed
May 7, 2018
src/Adyen/Client.php
Outdated
| const ENDPOINT_CHECKOUT_TEST = "https://checkout-test.adyen.com"; | ||
| const ENDPOINT_CHECKOUT_LIVE = "https://checkout-live.adyen.com"; | ||
| const ENDPOINT_CHECKOUT_UTILITY_TEST = "https://checkout-test.adyen.com/checkoutUtility"; | ||
| const ENDPOINT_CHECKOUT_UTILITY_LIVE = "https://checkout-live.adyen.com/checkoutUtility"; |
Aleffio
changed the title
lancergr
reviewed
May 8, 2018
tests/MockTest/CheckoutTest.php
Outdated
| } catch (\Exception $e) { | ||
| } | ||
|
|
||
| $this->assertEquals('Adyen\AdyenException', get_class($e)); |
There was a problem hiding this comment.
better put these exception assertions within catch and add a fail() call after line 58
…ot provided, added fail() call to the failureTests
lancergr
approved these changes
May 9, 2018
rikterbeek
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ient to make it testable
Description
added the following endpoints:
SDK Integration:
/setup
/verify
API Integration:
/paymentMethods
/payments
/payments/details
Checkout Utility:
/originKeys