fix local unit test running caused by the missing date_default_timezone_set #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working on the api library standalone on local When this setting is set true then the missing defaults that can cause issues are being set
rkewlani
requested review from
lancergr,
rikterbeek and
maassenbas
and removed request for
rikterbeek
Aleffio
approved these changes
Oct 12, 2018
rikterbeek
approved these changes
Oct 13, 2018
rkewlani
approved these changes
Oct 15, 2018
lancergr
reviewed
Oct 17, 2018
tests/TestCase.php
Outdated
| */ | ||
| private function setDefaultsDuringDevelopment() | ||
| { | ||
| if ($this->isDev()) { |
There was a problem hiding this comment.
what's the downside on skipping the dev flag and isDev for these unit tests?
There was a problem hiding this comment.
Right now nothing because the only setting we apply is the default time zone and only if the client doesn't have a default value for that, but for the future I'd say this flag will be useful
If you say that do it more agile and skip the parts that's not really necessary for us now I can remove it
There was a problem hiding this comment.
I believe is better to remove for simplicity. Unit tests are mostly considered dev env anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new setting to the config/tests.ini where it can be set if you are
working on the api library standalone on local
When this setting is set true then the missing defaults that can cause
issues are being set