Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-4149] OFFER_CLOSED and AUTHORISATION notification with success=false should be processed after awhile #141

Closed
ataberkylmz opened this issue Feb 17, 2021 · 0 comments · Fixed by #142
Assignees

Comments

@ataberkylmz
Copy link
Contributor

Describe the bug
Very similar issue to the one we had with Magento 2 plugin. Corresponding PR: Adyen/adyen-magento2#910

  1. We should delay the processing of OFFER_CLOSED notifications and AUTHORISATION notification with success=false by 10 minutes or a reasonable amount of time (which should give shopper enough timeframe to complete the order successfully). Corresponding Magento code here for the reference.
  2. Then check the status of the order and process OFFER_CLOSED and AUTHORISATION notification with success=false​ only if the status of the order is not complete or paid. Corresponding Magento code here for the reference.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants