Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #51

Open
Andrew-S-Rosen opened this issue Apr 30, 2023 · 0 comments
Open

Update PR template #51

Andrew-S-Rosen opened this issue Apr 30, 2023 · 0 comments

Comments

@Andrew-S-Rosen
Copy link
Contributor

Andrew-S-Rosen commented Apr 30, 2023

What should we add?

The PR template has "I have updated the documentation, VERSION, and CHANGELOG accordingly" as a checkbox. However, the VERSION does not need to be updated since it will be done so automatically.

It also says:
⚠️ Increment the version number in the /VERSION file. If this is a bugfix, increment the patch version (the rightmost number), for example 0.18.2 becomes 0.18.3. If it's a new feature, increment the minor version (the middle number), for example 0.18.2 becomes 0.19.0.
⚠️ Add a note to /CHANGELOG.md with your version number and the date, summarizing the changes.

Both of these are not currently accurate since the user is not supposed to increment the version number manually or set the date.

The same should be done in the main covalent repo too I think...

@Andrew-S-Rosen Andrew-S-Rosen changed the title Update PR template Update PR template (and a few readme updates) May 1, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Update PR template (and a few readme updates) Update PR template May 1, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Update PR template Update PR template and badges May 1, 2023
@Andrew-S-Rosen Andrew-S-Rosen changed the title Update PR template and badges Update PR template May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant