Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete producePromise package #1377

Closed
erights opened this issue Aug 5, 2020 · 2 comments · Fixed by #1542
Closed

Remove obsolete producePromise package #1377

erights opened this issue Aug 5, 2020 · 2 comments · Fixed by #1542
Assignees
Labels
bug Something isn't working

Comments

@erights
Copy link
Member

erights commented Aug 5, 2020

About

"packages/producePromise",

at
#1329 (review)
@warner writes:

I think this was a typo, because this PR did not also rename packages/produce-promise/everything to packages/producePromise/. This doesn't seem to be hurting anything (maybe yarn just ignores a workspace entry when the corresponding directory is missing?), but it effectively deletes @agoric/produce-promise. So @erights you might as well go ahead and make a PR to delete the packages/produce-promise/ directory, this entry in workspaces, and the .github/workflows/test-all-packages.yml job.

@erights erights added the bug Something isn't working label Aug 5, 2020
@erights erights self-assigned this Aug 5, 2020
@warner
Copy link
Member

warner commented Aug 5, 2020

@michaelfig oh, did we want to publish "one last version" of @agoric/produce-promise with a deprecation message and a README that points users at the new name?

Probably not important, but if we did want to do that, then before deleting producePromise, we'd want to rename it back to produce-promise, add the deprecation stuff, make a release, and then delete it.

@michaelfig
Copy link
Member

Probably not important, but if we did want to do that, then before deleting producePromise, we'd want to rename it back to produce-promise, add the deprecation stuff, make a release, and then delete it.

I think it is legitimate to branch off of an earlier commit, make and tag a release, and never have that tag hit the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants