Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off eslint's import/prefer-default-export globally #1469

Closed
michaelfig opened this issue Aug 14, 2020 · 0 comments · Fixed by #1463
Closed

Turn off eslint's import/prefer-default-export globally #1469

michaelfig opened this issue Aug 14, 2020 · 0 comments · Fixed by #1463
Assignees
@michaelfig
Labels
tooling repo-wide infrastructure

Comments

@michaelfig
Copy link
Member

We should turn off import/prefer-default-export globally. I thought we had. I've certainly written a lot of named exports without needing to suppress any warnings. I prefer named exports.

Originally posted by @erights in https://github.com/_render_node/MDExOlB1bGxSZXF1ZXN0NDY3NTg0MDcw/pull_requests/unread_timeline
@michaelfig michaelfig self-assigned this Aug 14, 2020
@michaelfig michaelfig added the tooling repo-wide infrastructure label Aug 14, 2020
@michaelfig michaelfig changed the title We should turn off import/prefer-default-export globally. I thought we had. I've certainly written a lot of named exports without needing to suppress any warnings. I prefer named exports. Turn off eslint's import/prefer-default-export globally Aug 14, 2020
@michaelfig michaelfig mentioned this issue Aug 14, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelfig michaelfig

Labels
tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to remove extraneous HandledPromise shim dependencies Agoric/agoric-sdk
1 participant
@michaelfig