Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On XSnap, switch from using sloppy eval to using the builtin compartment evaluator #2480

Open
erights opened this issue Feb 19, 2021 · 2 comments
Assignees
Labels
blocked_by_XSupgrade items that require an XS upgrade before they can be solved. endo needs-design ses vaults_triage DO NOT USE xsnap the XS execution tool

Comments

@erights
Copy link
Member

erights commented Feb 19, 2021

endojs/endo#31 is an example of a bug we simple cannot fix as long as we're using the eight magic lines of code to safely evaluate. XSnap has compartments whose semantics started us on our compartment semantics. But currently we're not using their builtin compartments yet because of all the semantic gaps on modules and import namespaces that we need to reconcile.

However, those builtin compartments do have per-compartment globals and per-compartment eval and Function that work according to SES rules, which have not drifted. Even though the modules/imports issue mean we still need to build our own compartments or their for now, we could directly use their evaluator for confined execution. This would fix endojs/endo#31 and is really the only practical way to fix it.

@dckc
Copy link
Member

dckc commented Feb 19, 2021

It's not obvious to me how we would do this, so I'm adding the design label.

@erights
Copy link
Member Author

erights commented Dec 26, 2022

See also endojs/endo#730 , which is dup-ish, but we're keeping both open for now.

@ivanlei ivanlei added the vaults_triage DO NOT USE label May 17, 2023
@turadg turadg unassigned dckc Aug 14, 2023
@aj-agoric aj-agoric added the blocked_by_XSupgrade items that require an XS upgrade before they can be solved. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked_by_XSupgrade items that require an XS upgrade before they can be solved. endo needs-design ses vaults_triage DO NOT USE xsnap the XS execution tool
Projects
None yet
Development

No branches or pull requests

6 participants