-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable checkJs
to switch opt-in to opt-out for tsc
#4885
Comments
More more motivation: the |
Weird, I didn't think tsc reported issues in Aka if we solved #6343 |
Example:
Many have more than that.
I think that's right, because the |
What is the Problem Being Solved?
Many files in the repo aren't type checked at all because they don't have
@ts-check
and our tsc compiler options are just toallowJs
(implied by usingjsconfig.json
).Description of the Design
Enable
checkJs
option (ref) which "is the equivalent of including// @ts-check
at the top of all JavaScript files which are included in your project".Note that this is blocked on #4560 because anything greater than the default
maxNodeModuleJsDepth
of zero means enablingcheckJs
will make tsc check inside the node_modules directory.Security Considerations
--
Test Plan
--
The text was updated successfully, but these errors were encountered: